Re: Add pg_file_sync() to adminpack - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add pg_file_sync() to adminpack
Date
Msg-id 20200124055645.GC1581@paquier.xyz
Whole thread Raw
In response to Re: Add pg_file_sync() to adminpack  (Arthur Zakirov <zaartur@gmail.com>)
Responses Re: Add pg_file_sync() to adminpack  (Julien Rouhaud <rjuju123@gmail.com>)
Re: Add pg_file_sync() to adminpack  (Arthur Zakirov <zaartur@gmail.com>)
List pgsql-hackers
On Fri, Jan 24, 2020 at 01:28:29PM +0900, Arthur Zakirov wrote:
> It is compiled and passes the tests. There is the documentation and it is
> built too without an error.
>
> It seems that consensus about the returned type was reached and I marked the
> patch as "Ready for Commiter".

+       fsync_fname_ext(filename, S_ISDIR(fst.st_mode), false, ERROR);
One comment here: should we warn better users in the docs that a fsync
failule will not trigger a PANIC here?  Here, fsync failure on heap
file => ERROR => potential data corruption.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: BUG #16109: Postgres planning time is high across version(Expose buffer usage during planning in EXPLAIN)
Next
From: Masahiko Sawada
Date:
Subject: Re: Transactions involving multiple postgres foreign servers, take 2