Re: error context for vacuum to include block number - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: error context for vacuum to include block number
Date
Msg-id 20200122021954.GA5885@alvherre.pgsql
Whole thread Raw
In response to Re: error context for vacuum to include block number  (Justin Pryzby <pryzby@telsasoft.com>)
List pgsql-hackers
On 2020-Jan-21, Justin Pryzby wrote:

> And I knew that, so (re)tested that the extracted patches would apply, but it
> looks like maybe the patch checker is less smart (or more strict) than git, so
> it didn't work after all.

Honestly, I think we should be scared of a patch applier that ignored
differences in context lines.  After all, that's why those context lines
are there -- so that they provide additional location cues for the lines
being modified.  If you allow random other lines to be there, you could
be inserting stuff in arbitrarily erroneous places.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Block level parallel vacuum
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Block level parallel vacuum