Re: pgsql: Use native methods to open input in TestLib::slurp_fileon Windo - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Use native methods to open input in TestLib::slurp_fileon Windo
Date
Msg-id 20191126044110.GB5435@paquier.xyz
Whole thread Raw
In response to pgsql: Use native methods to open input in TestLib::slurp_file on Windo  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Use native methods to open input in TestLib::slurp_file onWindo  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Re: pgsql: Use native methods to open input in TestLib::slurp_file onWindo  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-committers
Hi Andrew,

On Sun, Nov 24, 2019 at 11:53:31PM +0000, Andrew Dunstan wrote:
> Use native methods to open input in TestLib::slurp_file on Windows.
>
> It is hoped that this will avoid some errors that we have seen before,
> but lately with greater frequency, in buildfarm animals.
>
> For now apply only to master. If this proves effective it can be
> backpatched.
>
> Discussion: https://postgr.es/m/13900.1572839580@sss.pgh.pa.us

jacana is visibly complaining about this commit:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2019-11-25%2020%3A19%3A49

The tests of commit_ts are failing:
Nov 25 16:46:52 t/001_base.........# Looks like your test exited with
255 before it could output anything.
Nov 25 16:46:52 dubious
Nov 25 16:46:52        Test returned status 255 (wstat 65280, 0xff00)
Nov 25 16:46:52 DIED. FAILED tests 1-2
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Add safeguards for pg_fsync() called with incorrectly-opened fds
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures