Re: [PATCH] Do not use StdRdOptions in Access Methods - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Do not use StdRdOptions in Access Methods
Date
Msg-id 20191113070520.GV1549@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Do not use StdRdOptions in Access Methods  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: [PATCH] Do not use StdRdOptions in Access Methods  (Nikolay Shaplov <dhyan@nataraj.su>)
Re: [PATCH] Do not use StdRdOptions in Access Methods  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Wed, Nov 13, 2019 at 02:29:49PM +0900, Amit Langote wrote:
> On Wed, Nov 13, 2019 at 2:18 PM Michael Paquier <michael@paquier.xyz> wrote:
>> There could be an argument for keeping
>> GET_STRING_RELOPTION actually which is still useful to get a string
>> value in an option set using the stored offset, and we have
>> the recently-added dummy_index_am in this category.  Any thoughts?
>
> Not sure, maybe +0.5 on keeping GET_STRING_RELOPTION.

Thinking more about it, I would tend to keep this one around.  I'll
wait a couple of days before coming back to it.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Ought to use heap_multi_insert() for pg_attribute/dependinsertions?
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] use separate PartitionedRelOptions structure to storepartitioned table options