Re: Change atoi to strtol in same place - Mailing list pgsql-hackers

From Joe Nelson
Subject Re: Change atoi to strtol in same place
Date
Msg-id 20191004032350.a5lrh6yps3dmvsqn@begriffs.com
Whole thread Raw
In response to Re: Change atoi to strtol in same place  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Change atoi to strtol in same place
List pgsql-hackers
Kyotaro Horiguchi wrote:
> > pg_standby: -k keepfiles could not parse 'hoge' as integer
>
> I didn't checked closely, but -k of pg_standby's message looks
> somewhat strange. Needs a separator?

Good point, how about this:

    pg_standby: -k keepfiles: <localized error message>

> Building a sentense just concatenating multiple nonindependent
> (or incomplete) subphrases makes translation harder.

I could have pg_strtoint64_range() wrap its error messages in _() so
that translators could customize the messages prior to concatenation.

    *error = psprintf(_("could not parse '%s' as integer"), str);

Would this suffice?



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Partitioning versus autovacuum
Next
From: Amit Kapila
Date:
Subject: Re: Proposal: Make use of C99 designated initialisers fornulls/values arrays