Re: Change atoi to strtol in same place - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Change atoi to strtol in same place
Date
Msg-id 20191001.194621.122195483.horikyota.ntt@gmail.com
Whole thread Raw
In response to Re: Change atoi to strtol in same place  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Change atoi to strtol in same place
List pgsql-hackers
At Tue, 01 Oct 2019 19:32:08 +0900 (Tokyo Standard Time), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
<20191001.193208.264851337.horikyota.ntt@gmail.com>
> Hello.
> 
> At Sun, 29 Sep 2019 23:51:23 -0500, Joe Nelson <joe@begriffs.com> wrote in <20190930045123.GC68117@begriffs.com>
> > Alvaro Herrera wrote:
> > > ... can we have a new patch?
> > 
> > OK, I've attached v4. It works cleanly on 55282fa20f with
> > str2int-16.patch applied. My patch won't compile without the other one
> > applied too.
> > 
> > Changed:
> > [x] revert my changes in common/Makefile
> > [x] rename arg_utils.[ch] to option.[ch]
> > [x] update @pgfeutilsfiles in Mkvcbuild.pm
> > [x] pgindent everything
> > [x] get rid of atoi() in more utilities

I didn't checked closely, but -k of pg_standby's message looks
somewhat strange. Needs a separator?

> pg_standby: -k keepfiles could not parse 'hoge' as integer

Building a sentense just concatenating multiple nonindependent
(or incomplete) subphrases makes translation harder.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Change atoi to strtol in same place
Next
From: Greg Nancarrow
Date:
Subject: Re: Libpq support to connect to standby server as priority