On Mon, Aug 26, 2019 at 09:03:08PM +0000, Tom Lane wrote:
> Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.
>
> If a test case tried to set an invalid value of synchronous_standby_names,
> the test script didn't detect that, which seems like a bad idea.
> Noticed while testing a proposed patch that broke some of these
> test cases.
Just for the note. I think that this needs a closer lookup and I am
afraid that there are more issues like this one. For example, in
012_subtransactions.pl, pg_reload_conf() is called with
PostgresNode::psql without checking for an error which is a bad idea
after switching to synchonous replication. Most of the transactions
done in this scrupt should also complain immediately on an error.
--
Michael
