On 2019-Aug-21, Michael Paquier wrote:
> + if (PQsocket(conn) >= FD_SETSIZE)
> + {
> + fprintf(stderr, "too many jobs for this platform's select()\n");
> + exit(1);
> + }
BTW why fprintf? Since you can get into this by careless use of -j,
ISTM that this should be a translatable string. I'd consider
pg_log_fatal(). Maybe something like "Argument of -j too large for this
platform -- try %d", numslots - i.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
