On Wed, Jul 24, 2019 at 04:41:05PM +1200, Thomas Munro wrote:
> On Wed, Jul 24, 2019 at 3:52 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> > I guess we should do that too. I don't know how to write Perl but I'll try...
>
> Does this look about right?
Some comments from here. I have not tested the patch.
I would recommend using TestLib::system_log instead of plain system().
The command should be a list of arguments with one element per
argument (see call of system_log in PostgresNode.pm for example). The
indentation is incorrect, and that I would make the retry longer as I
got the feeling that on slow machines we could still have issues. We
also usually tend to increase the timeout up to 5 minutes, and the
sleep phases make use of Time::HiRes::usleep.
--
Michael
