Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11 - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11
Date
Msg-id 20190709013105.GA1345@paquier.xyz
Whole thread Raw
In response to Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Jul 08, 2019 at 03:21:41PM -0400, Tom Lane wrote:
> Having said that, join_hash.sql in particular seems to have zero
> value if it's not testing hash joins, so I think it'd be reasonable
> for it to override a global enable_hashjoin = off setting.  None of
> the other regression test scripts seem to take nearly as much of a
> performance hit from globally forcing poor plans.

I am a bit confused here.  Don't you mean to have enable_hashjoin =
*on* at the top of hash_join.sql instead like in the attached?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCH v4] Add \warn to psql
Next
From: Tomas Vondra
Date:
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)