Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11
Date
Msg-id 16391.1562638852@sss.pgh.pa.us
Whole thread Raw
In response to Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Jul 08, 2019 at 03:21:41PM -0400, Tom Lane wrote:
>> Having said that, join_hash.sql in particular seems to have zero
>> value if it's not testing hash joins, so I think it'd be reasonable
>> for it to override a global enable_hashjoin = off setting.  None of
>> the other regression test scripts seem to take nearly as much of a
>> performance hit from globally forcing poor plans.

> I am a bit confused here.  Don't you mean to have enable_hashjoin =
> *on* at the top of hash_join.sql instead like in the attached?

Right, overriding any enable_hashjoin = off that might've come from
PGOPTIONS or wherever.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Jamison, Kirk"
Date:
Subject: RE: [PATCH] Speedup truncates of relation forks
Next
From: Tom Lane
Date:
Subject: Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11