Re: pgsql: Drop test user when done with it. - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Drop test user when done with it.
Date
Msg-id 20190627081222.GC3509@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Drop test user when done with it.  (Stephen Frost <sfrost@snowman.net>)
List pgsql-committers
On Wed, Jun 26, 2019 at 03:07:33PM -0400, Stephen Frost wrote:
> Yes, thanks, and specifically this:
>
> https://www.postgresql.org/message-id/20181130163728.GE3415%40tamriel.snowman.net
>
> Adding 'DROP IF EXISTS' to the top to have things cleaned up so that the
> run can be repeated is fine.  Removing things at the end of the test
> script would defeat the entire purpose of those tests.

The problem is that if you do an installcheck, then the role persists
in the instance of Postgres installed.  That's not a good thing, and
contrary to the test policy.  And your solution does nothing about
that.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Amit Langote
Date:
Subject: Re: pgsql: Fix partitioned index creation with foreign partitions
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Update comment