Re: be-gssapi-common.h should be located in src/include/libpq/ - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: be-gssapi-common.h should be located in src/include/libpq/
Date
Msg-id 20190608012439.GB7228@paquier.xyz
Whole thread Raw
In response to Re: be-gssapi-common.h should be located in src/include/libpq/  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: be-gssapi-common.h should be located in src/include/libpq/
List pgsql-hackers
On Fri, Jun 07, 2019 at 09:52:26AM +0200, Daniel Gustafsson wrote:
> While looking at libpq.h I noticed what seems to be a few nitpicks: the GSS
> function prototype isn’t using the common format of having a comment specifying
> the file it belongs to; ssl_loaded_verify_locations is defined as extern even
> though it’s only available under USE_SSL (which works fine since it’s only
> accessed under USE_SSL but seems kinda wrong); and FeBeWaitSet is not listed
> under the pqcomm.c prototypes like how the extern vars from be-secure.c are.
> All of these are in the attached.

Indeed, this makes the header more consistent.  Thanks for noticing.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: be-gssapi-common.h should be located in src/include/libpq/
Next
From: Michael Paquier
Date:
Subject: Re: Temp table handling after anti-wraparound shutdown (Was: BUG#15840)