Re: be-gssapi-common.h should be located in src/include/libpq/ - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: be-gssapi-common.h should be located in src/include/libpq/
Date
Msg-id 0ACBDEC5-D49C-4B1B-AF27-8E396426F877@yesql.se
Whole thread Raw
In response to be-gssapi-common.h should be located in src/include/libpq/  (Michael Paquier <michael@paquier.xyz>)
Responses Re: be-gssapi-common.h should be located in src/include/libpq/
List pgsql-hackers
> On 7 Jun 2019, at 06:34, Michael Paquier <michael@paquier.xyz> wrote:

> Any objections to something like the attached?

No objections to moving the file per the patch.

While looking at libpq.h I noticed what seems to be a few nitpicks: the GSS
function prototype isn’t using the common format of having a comment specifying
the file it belongs to; ssl_loaded_verify_locations is defined as extern even
though it’s only available under USE_SSL (which works fine since it’s only
accessed under USE_SSL but seems kinda wrong); and FeBeWaitSet is not listed
under the pqcomm.c prototypes like how the extern vars from be-secure.c are.
All of these are in the attached.

cheers ./daniel


Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Should we warn against using too many partitions?
Next
From: Kyotaro Horiguchi
Date:
Subject: Wording variations in descriptions of gucs.