Re: Small review comment on pg_checksums - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Small review comment on pg_checksums
Date
Msg-id 20190606132128.GB1978@paquier.xyz
Whole thread Raw
In response to Small review comment on pg_checksums  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Small review comment on pg_checksums
List pgsql-hackers
On Thu, Jun 06, 2019 at 05:16:30PM +0900, Masahiko Sawada wrote:
> So I'd like to propose a small fix for that; move the comment to the
> right place and add another comment. Please find an attached small
> patch.

No objections to that.  Perhaps we should also mention that this does
not protect from someone starting the cluster concurrently and that
the reason why we require a clean shutdown is that we may get checksum
failures because of torn pages?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Ian Barwick
Date:
Subject: doc: pg_trgm missing description for GUC"pg_trgm.strict_word_similarity_threshold"
Next
From: Alvaro Herrera
Date:
Subject: Re: Pluggable Storage - Andres's take