Re: Small review comment on pg_checksums - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Small review comment on pg_checksums
Date
Msg-id CAD21AoCd3PPPDVisu54nvKdpwx3kOsWo627TdD74jBxacbGcFw@mail.gmail.com
Whole thread Raw
In response to Re: Small review comment on pg_checksums  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Small review comment on pg_checksums
List pgsql-hackers
On Thu, Jun 6, 2019 at 10:21 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Jun 06, 2019 at 05:16:30PM +0900, Masahiko Sawada wrote:
> > So I'd like to propose a small fix for that; move the comment to the
> > right place and add another comment. Please find an attached small
> > patch.
>
> No objections to that.  Perhaps we should also mention that this does
> not protect from someone starting the cluster concurrently and that
> the reason why we require a clean shutdown is that we may get checksum
> failures because of torn pages?

Agreed. Please find an attached patch.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] Block level parallel vacuum
Next
From: Masahiko Sawada
Date:
Subject: Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"