Re: Accidental setting of XLogReaderState.private_data ? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Accidental setting of XLogReaderState.private_data ?
Date
Msg-id 20190416061300.GH2673@paquier.xyz
Whole thread Raw
In response to Re: Accidental setting of XLogReaderState.private_data ?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Apr 15, 2019 at 11:06:18AM -0400, Tom Lane wrote:
> Hmm.  The second, duplicate assignment is surely pointless, but I think
> that setting the ctx as the private_data is a good idea.  It hardly seems
> out of the question that it might be needed in future.

Agreed that we should keep the assignment done with
XLogReaderAllocate().  I have committed the patch which removes the
useless assignment though.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Autovacuum-induced regression test instability
Next
From: Michael Paquier
Date:
Subject: Re: REINDEX CONCURRENTLY 2.0