Postgres Pro
Downloads
Home   >   mailing lists

Re: XLogInsert() of dangling pointer while logging replica identity - Mailing list pgsql-hackers

From Andres Freund
Subject Re: XLogInsert() of dangling pointer while logging replica identity
Date
Msg-id 20190209110206.zrih4xszrx7xbrtf@alap3.anarazel.de
Whole thread Raw
In response to Re: XLogInsert() of dangling pointer while logging replica identity  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On 2019-02-01 10:38:49 +0900, Michael Paquier wrote:
> On Thu, Jan 31, 2019 at 11:51:36PM +0300, Stas Kelvich wrote:
> >   It seems that heapam.c:3082 calls XLogRegisterData() with an argument
> > allocated on stack, but following call to XLogInsert() happens after
> > end of context for that variable.
> >   Issue spotted by clang's AddressSanitizer. Fix attached.
> 
> Oh, good catch.  Committed and back-patched down to 9.4.

Thanks Stas and Michael!

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Documentation and code don't agree about partitioned tableUPDATEs
Next
From: Alexander Kuzmenkov
Date:
Subject: Re: First-draft release notes for next week's releases