Old protocol fastpath calls borked? - Mailing list pgsql-hackers

From Andres Freund
Subject Old protocol fastpath calls borked?
Date
Msg-id 20190124215032.wnzx5pw3gyxfusgr@alap3.anarazel.de
Whole thread Raw
Responses Re: Old protocol fastpath calls borked?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

In parse_fcall_arguments_20():

c0a8c3ac13f8 (Tom Lane           2003-05-08 18:16:37 +0000 579)         argsize = pq_getmsgint(msgBuf, 4);
0ac6298bb8ac (Tom Lane           2003-05-09 18:08:48 +0000 580)         if (argsize == -1)
0ac6298bb8ac (Tom Lane           2003-05-09 18:08:48 +0000 581)         {
0ac6298bb8ac (Tom Lane           2003-05-09 18:08:48 +0000 582)             fcinfo->argnull[i] = true;
147d4bf3e5e3 (Tom Lane           2006-04-04 19:35:37 +0000 583)             fcinfo->arg[i] =
OidReceiveFunctionCall(typreceive,NULL,
 
147d4bf3e5e3 (Tom Lane           2006-04-04 19:35:37 +0000 584)
typioparam,-1);
 
0ac6298bb8ac (Tom Lane           2003-05-09 18:08:48 +0000 585)             continue;
c0a8c3ac13f8 (Tom Lane           2003-05-08 18:16:37 +0000 586)         }

we appear to constantly setting argnull to true for all arguments?  Since,
apparently, 2003?  I don't have a test-program at hand, but that kind of seems
to suggest this never really has been used?

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Delay locking partitions during INSERT and UPDATE
Next
From: Tom Lane
Date:
Subject: Re: Old protocol fastpath calls borked?