Re: ArchiveEntry optional arguments refactoring - Mailing list pgsql-hackers

From Andres Freund
Subject Re: ArchiveEntry optional arguments refactoring
Date
Msg-id 20190123170701.ghp6fkg5cgdr5bpl@alap3.anarazel.de
Whole thread Raw
In response to Re: ArchiveEntry optional arguments refactoring  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hi,

On 2019-01-23 13:58:07 -0300, Alvaro Herrera wrote:
> I'd use ArchiveEntryOpts as struct name; ArchiveOpts sounds wrong.

Brevity would be of some advantage IMO, because it'll probably determine
how pgindent indents the arguments, because the struct name will be in
the arguments.


> Also, the struct members could use better names -- "defn" for example
> could perhaps be "createStmt" (to match dropStmt/copyStmt), and expand
> "desc" to "description".

True.

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: ArchiveEntry optional arguments refactoring
Next
From: Andres Freund
Date:
Subject: Re: ArchiveEntry optional arguments refactoring