Re: Thread-unsafe coding in ecpg - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Thread-unsafe coding in ecpg
Date
Msg-id 20190121202150.wf5o353x3ibiuomt@alap3.anarazel.de
Whole thread Raw
In response to Re: Thread-unsafe coding in ecpg  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Thread-unsafe coding in ecpg  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2019-01-21 15:05:23 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Seems jacana might not have like this change?
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2019-01-21%2019%3A01%3A28
> 
> Hmm.  So mingw doesn't provide access to _configthreadlocale().
> That's unfortunate, at least if we think that mingw is still a viable
> production platform, because it means we can't make ecpg thread-safe
> on that platform.
> 
> Is there a newer version of mingw that does have this functionality?
> I'm not sure whether to install a version check or just assume that
> it's never there.

It does seem like newer versions do have it:
https://sourceforge.net/p/mingw-w64/mailman/message/34765722/
https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-crt/misc/_configthreadlocale.c

We could just refuse to support thread safety on mingw if that's not
supported? Or is that too aggressive?

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Re: Thread-unsafe coding in ecpg
Next
From: Tom Lane
Date:
Subject: Re: Thread-unsafe coding in ecpg