Re: Ryu floating point output patch - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Ryu floating point output patch
Date
Msg-id 20181214182922.k7uzdtiusrosaixr@alap3.anarazel.de
Whole thread Raw
In response to Re: Ryu floating point output patch  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Ryu floating point output patch
Re: Ryu floating point output patch
List pgsql-hackers
Hi,

On 2018-12-14 13:25:29 -0500, Tom Lane wrote:
> Our track record in borrowing code from "upstream" projects is pretty
> miserable: almost without exception, we've found ourselves stuck with
> maintaining such code ourselves after a few years.  I don't see any
> reason to think that wouldn't be true here; in fact there's much more
> reason to worry here than we had for, eg, borrowing the regex code.
> The maintenance track record of this github repo appears to span six
> months, and it's now been about four months since the last commit.
> It might be abandonware already.

It's been absorbed into MSVC's standard library and a bunch of other
projects, so there's certainly some other prominent adoption.

The last commit was a month ago, no? November 6th afaict.


> Is this a path we really want to go down?  I'm not convinced the
> cost/benefit ratio is attractive.

float->text conversion is one of the major bottlenecks when backing up
postgres, it's definitely a pain-point in practice. I've not really seen
a nicer implementation anywhere, not even close.

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Ryu floating point output patch
Next
From: Tom Lane
Date:
Subject: Re: removal of dangling temp tables