Postgres Pro
Downloads
Home   >   mailing lists

Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS) - Mailing list pgsql-hackers

From Kyotaro HORIGUCHI
Subject Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS)
Date
Msg-id 20181119.132408.139732554.horiguchi.kyotaro@lab.ntt.co.jp
Whole thread Raw
In response to Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS)  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS)  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Tree view 
At Sat, 17 Nov 2018 11:15:54 -0300, Alvaro Herrera <alvherre@2ndquadrant.com> wrote in
<20181117141554.4dkx2u4j6md3bqdh@alvherre.pgsql>
> Is this patch committable now?

I don't think so. We should make a decision on a point.

I was a bit confused (sorry) but IIUIC Haribabu suggested that
the RBM_ZERO_ON_ERROR case should be included to read (not just
ignored). I'm on it.  I think that RPM_ZERO_* other than ON_ERROR
cases could be a kind of hit but I don't insist on it.

So, I think we should decide on at least the ON_ERROR case before
this becomes commttable.

The another counter could be another issue. I don't object to add
the counter but I'm not sure what is the suitable name.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Function to promote standby servers
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] XLogReadRecord returns pointer to currently read page