Re: [PATCH] XLogReadRecord returns pointer to currently read page - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] XLogReadRecord returns pointer to currently read page
Date
Msg-id 20181119042434.GD4400@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] XLogReadRecord returns pointer to currently read page  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
On Mon, Nov 19, 2018 at 12:28:06PM +0900, Kyotaro HORIGUCHI wrote:
> Yeah, it is incorrect in some sense, but the comment was
> suggesting the lifetime of the pointed record. So I'd like to
> have a comment like this instead.

I think that we can still live without as it is not the business of this
routine to be careful how the lifetime of a record read is handled, but
that's part of the internals of XLogReader.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS)
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Restricting maximum keep segments by repslots