Re: Wrong aggregate result when sorting by a NULL value - Mailing list pgsql-bugs

From Andres Freund
Subject Re: Wrong aggregate result when sorting by a NULL value
Date
Msg-id 20181103230837.6rv63tajaodxmp6j@alap3.anarazel.de
Whole thread Raw
In response to Re: Wrong aggregate result when sorting by a NULL value  (Andres Freund <andres@anarazel.de>)
Responses Re: Wrong aggregate result when sorting by a NULL value  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-bugs
Hi,

On 2018-11-03 15:27:09 -0700, Andres Freund wrote:
> On 2018-11-03 18:18:40 -0400, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> > > And pushed. Thanks Ondřej for the report, thanks Tom & Andrew for
> > > identifying the issue.
> > 
> > Hm, buildfarm seems less than pleased.  Did you miss making a
> > corresponding change in the JIT code?
> 
> Hm, I'm somewhat confused, let me look into that. The JIT code shouldn't
> really need to be changed here - it's the *generation* of expression
> steps that's going wrong - which then later get turned into JITed code,
> but that part worked previously for other expressions.

Turns out it's not a great idea to generate EEOP_AGG_STRICT_INPUT_CHECK
expressions with nargs = 0. Head -> Desk.  Pushed a fix (+ new
assertion).

Thanks!

Andres Freund


pgsql-bugs by date:

Previous
From: Andres Freund
Date:
Subject: Re: Wrong aggregate result when sorting by a NULL value
Next
From: Michael Paquier
Date:
Subject: Re: Unable to copy large (>2GB) files using PostgreSQL 11 (Windows)