Postgres Pro
Downloads
Home   >   mailing lists

Resetting PGPROC atomics in ProcessInit() - Mailing list pgsql-hackers

From Andres Freund
Subject Resetting PGPROC atomics in ProcessInit()
Date
Msg-id 20181027104138.qmbbelopvy7cw2qv@alap3.anarazel.de
Whole thread Raw
Responses Re: Resetting PGPROC atomics in ProcessInit()  (Amit Kapila <amit.kapila16@gmail.com>)
Re: Resetting PGPROC atomics in ProcessInit()  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

I just noticed, while working on a patch adding things to PGPROC, that
the group clearning patches for the proc array and clog reset atomics in
InitProcess().

I'm not a big fan of that, because it means that it's not safe to look
at the atomics of backends that aren't currently in use.  Is there any
reason to not instead initialize them in InitProcGlobal() and just
assert in InitProcess() that they're 0?  If they're not, we'd be in deep
trouble anyway, no?

Greetings,

Andres Freund

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Postgres restore issue
Next
From: Peter Eisentraut
Date:
Subject: Re: Remove obsolete pg_attrdef.adsrc column