Re: pgsql: Add TAP tests for pg_verify_checksums - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pgsql: Add TAP tests for pg_verify_checksums
Date
Msg-id 20181012060543.GE30064@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Add TAP tests for pg_verify_checksums  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Add TAP tests for pg_verify_checksums  (Michael Banck <michael.banck@credativ.de>)
List pgsql-hackers
On Fri, Oct 12, 2018 at 12:11:58PM +0900, Michael Paquier wrote:
> Agreed.  I am just working on a patch for v11- which uses a
> whitelist-based method instead of what is present now.  Reverting the
> tests to put the buildfarm to green could be done, but that's not the
> root of the problem.

So, I have coded this thing, and finish with the attached.  The
following file patterns are accepted for the checksums:
<digits>.<segment>
<digits>_<forkname>
<digits>_<forkname>.<segment>
I have added some tests on the way to make sure that all the patterns
get covered.  Please note that this skips the temporary files.

Thoughts?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: [HACKERS] [PATCH] Generic type subscripting
Next
From: "Ideriha, Takeshi"
Date:
Subject: Number of buckets/partitions of dshash