Postgres Pro
Downloads
Home   >   mailing lists

Use durable_unlink for .ready and .done files for WAL segment removal - Mailing list pgsql-hackers

From Michael Paquier
Subject Use durable_unlink for .ready and .done files for WAL segment removal
Date
Msg-id 20180928032827.GF1500@paquier.xyz
Whole thread Raw
Responses Re: Use durable_unlink for .ready and .done files for WAL segmentremoval  (Andres Freund <andres@anarazel.de>)
Re: Use durable_unlink for .ready and .done files for WAL segmentremoval  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Tree view 
Hi all,

While reviewing the archiving code, I have bumped into the fact that
XLogArchiveCleanup() thinks that it is safe to do only a plain unlink()
for .ready and .done files when removing a past segment.  I don't think
that it is a smart move, as on a subsequent crash we may still see
those, but the related segment would have gone away.  This is not really
a problem for .done files, but it could confuse the archiver to see some
.ready files about things that have already gone away.

Attached is a patch.  Thoughts?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Segfault when creating partition with a primary key and sql_droptrigger exists
Next
From: Andres Freund
Date:
Subject: Re: Use durable_unlink for .ready and .done files for WAL segmentremoval