Re: Use durable_unlink for .ready and .done files for WAL segmentremoval - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Use durable_unlink for .ready and .done files for WAL segmentremoval
Date
Msg-id 20180928034026.emkeqslnidihwber@alap3.anarazel.de
Whole thread Raw
In response to Use durable_unlink for .ready and .done files for WAL segment removal  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Use durable_unlink for .ready and .done files for WAL segmentremoval  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi,

On 2018-09-28 12:28:27 +0900, Michael Paquier wrote:
> While reviewing the archiving code, I have bumped into the fact that
> XLogArchiveCleanup() thinks that it is safe to do only a plain unlink()
> for .ready and .done files when removing a past segment.  I don't think
> that it is a smart move, as on a subsequent crash we may still see
> those, but the related segment would have gone away.  This is not really
> a problem for .done files, but it could confuse the archiver to see some
> .ready files about things that have already gone away.

Isn't that window fundamentally there anyway?

- Andres


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Use durable_unlink for .ready and .done files for WAL segment removal
Next
From: Amit Langote
Date:
Subject: Re: heap_sync seems rather oblivious to partitioned tables(wal_level=minimal)