Re: [HACKERS] Cutting initdb's runtime (Perl question embedded) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Cutting initdb's runtime (Perl question embedded)
Date
Msg-id 20180912073701.GM25160@paquier.xyz
Whole thread Raw
In response to Re: [HACKERS] Cutting initdb's runtime (Perl question embedded)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Cutting initdb's runtime (Perl question embedded)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Aug 10, 2018 at 02:31:25PM -0400, Tom Lane wrote:
> The cfbot points out that this has suffered bit-rot, so here's a rebased
> version --- no substantive changes.

+   /*
+    * Try to read the symlink.  If not there, not a symlink, etc etc, just
+    * quietly fail; the precise reason needn't concern us.
+    */
+   len = readlink(linkname, link_target, sizeof(link_target));

One thing that I can see changing with this patch is how timezone is set
in postgresql.conf.  For example, on HEAD I get 'Japan' while this patch
gives back 'Asia/Tokyo'.  Could it be an issue for countries with
multiple timezones?  I am not sure how Russian systems would react on
that for example.

The time cut for initdb is interesting for buildfarm members anyway, and
the patch looks in nice shape to me.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: make installcheck-world in a clean environment
Next
From: Christoph Berg
Date:
Subject: Re: Collation versioning