Re: More parallel pg_dump bogosities - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: More parallel pg_dump bogosities
Date
Msg-id 20180828193031.ahilzgnpkug6x45c@alvherre.pgsql
Whole thread Raw
In response to Re: More parallel pg_dump bogosities  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: More parallel pg_dump bogosities
List pgsql-hackers
On 2018-Aug-28, Tom Lane wrote:

> ... just when you thought it was safe to go back in the water ...
> 
> Doesn't pg_backup_archiver.c's identify_locking_dependencies() need to
> treat POLICY and ROW SECURITY items as requiring exclusive lock on
> the referenced table?  Those commands definitely acquire
> AccessExclusiveLock in a quick test.
> 
> I haven't looked hard, but I'm suspicious that other recently-added
> dump object types may have been missed here too,

I hadn't come across this locking dependency before, so it's pretty
likely that partitioned index attachment has a problem here.

> and even more suspicious that we'll forget this again in future.

... yeah, it seems easy to overlook the need to edit this.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: Dimension limit in contrib/cube (dump/restore hazard?)
Next
From: Asim R P
Date:
Subject: Re: Catalog corruption