Postgres Pro
Downloads
Home   >   mailing lists

Re: Non-reserved replication slots and slot advancing - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Non-reserved replication slots and slot advancing
Date
Msg-id 20180704015731.GE1672@paquier.xyz
Whole thread Raw
In response to Re: Non-reserved replication slots and slot advancing  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Non-reserved replication slots and slot advancing  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Tue, Jul 03, 2018 at 01:51:48PM -0400, Alvaro Herrera wrote:
> On 2018-Jul-03, Andres Freund wrote:
>> Fair enough, but that's what a plain slot allows you as well, pretty
>> fundamentally, no? The precise point at which recycling will be blocked
>> will differer, sure.

ReplicationSlotsComputeRequiredLSN() is careful enough to discard slots
which have their restart_lsn set to InvalidXLogRecPtr, so they are not
accounted within the minimum LSN calculated for segment retention.  Any
fake value added by a user advancing a non-reserved slot is.

At the end, are their any objections into fixing the issue and
tightening the advancing API?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Possible bug in logical replication.
Next
From: Etsuro Fujita
Date:
Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw with partitionwise join enabled.