Re: Possible bug in logical replication. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Possible bug in logical replication.
Date
Msg-id 20180622093954.GB16899@paquier.xyz
Whole thread Raw
In response to Re: Possible bug in logical replication.  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
On Fri, Jun 22, 2018 at 04:33:12PM +0900, Kyotaro HORIGUCHI wrote:
> pg_advance_replication_slots can advance uninitialized physical
> slots and that might not be good. (Logical slots always have
> initial invalid values in thw two lsn columns.)

The current logic is careful that users willing to move to a new
position cannot move in the future, but the logic is visibly wanted to
accept past values.  Petr, what do you think?  KeepLogSeg() won't return
negative values so some applications may take advantage of that.  Or
should advancing be simply disabled for non-initialized slots?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: add default parallel query to v10 release notes? (Re: [PERFORM]performance drop after upgrade (9.6 > 10))
Next
From: Amit Langote
Date:
Subject: Re: Wrong cost estimation for foreign tables join withuse_remote_estimate disabled