On 2018-06-12 15:05:16 +0100, Andrew Gierth wrote:
> >>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:
>
> > Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> >> The real question is why check_function_bodies doesn't cover this;
> >> there's a comment in fmgr_c_validator that this is deliberate, but it's
> >> rather unclear what the advantage is supposed to be:
>
> Tom> Error detection, ie did you spell the C symbol name correctly.
>
> Right, but surely restoring a dump is not the place to be doing that
> error check?
I'm not convinced that that's true. Checking that the target system has
the right shared library [version] installed isn't crazy, and you can't
do it at dump time.
If I wanted to do something about it - which I don't really - I'd argue
that check_function_bodies should become an enum or such.
Greetings,
Andres Freund
