Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Clear up perlcritic 'missing return' warning - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Clear up perlcritic 'missing return' warning
Date
Msg-id 20180611163439.3o6kjuhzhfrrspgi@alvherre.pgsql
Whole thread Raw
In response to Re: [PATCH] Clear up perlcritic 'missing return' warning  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: [PATCH] Clear up perlcritic 'missing return' warning
List pgsql-hackers
Tree view 
On 2018-May-26, Andrew Dunstan wrote:

> Not quite trivial but it's done - see
<https://github.com/PGBuildFarm/client-code/commit/92f94ba7df8adbcbdb08f0138d8b5e686611ba1f>.
> 
> crake is now set up to run this - see
<https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2018-05-26%2014%3A32%3A19&stg=perl-check>
> 
> So, are there any other objections?
> 
> The patch Mike supplied doesn't give us a clean run (at least on the machine
> I tested on), since it turns down the severity level to 4 but leaves some
> items unfixed. I propose to enable this policy at level 5 for now, and then
> remove that when we can go down to level 4 cleanly, and use its default
> setting at that stage.

Just to be clear -- this is done, right?  And we plan no further
enhancements in perlcritic area for pg11?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Locking B-tree leafs immediately in exclusive mode
Next
From: Andrew Dunstan
Date:
Subject: Re: [PATCH] Clear up perlcritic 'missing return' warning