On 06/11/2018 12:34 PM, Alvaro Herrera wrote: > On 2018-May-26, Andrew Dunstan wrote: > >> Not quite trivial but it's done - see <https://github.com/PGBuildFarm/client-code/commit/92f94ba7df8adbcbdb08f0138d8b5e686611ba1f>. >> >> crake is now set up to run this - see <https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2018-05-26%2014%3A32%3A19&stg=perl-check> >> >> So, are there any other objections? >> >> The patch Mike supplied doesn't give us a clean run (at least on the machine >> I tested on), since it turns down the severity level to 4 but leaves some >> items unfixed. I propose to enable this policy at level 5 for now, and then >> remove that when we can go down to level 4 cleanly, and use its default >> setting at that stage. > Just to be clear -- this is done, right? And we plan no further > enhancements in perlcritic area for pg11? > Yes, modulo https://www.postgresql.org/message-id/f3c12e2c-618f-cb6f-082b-a2f604dbe73f%402ndQuadrant.com I am hoping that we can get the perlcritic severity down to level 3 with a combination of policy settings and code remediation during the release 12 dev cycle. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
pgsql-hackers by date:
Соглашаюсь с условиями обработки персональных данных