Re: wal_consistency_checking reports an inconsistency on masterbranch - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: wal_consistency_checking reports an inconsistency on masterbranch
Date
Msg-id 20180413100840.GA27295@paquier.xyz
Whole thread Raw
In response to Re: wal_consistency_checking reports an inconsistency on master branch  (amul sul <sulamul@gmail.com>)
Responses Re: wal_consistency_checking reports an inconsistency on masterbranch  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Re: wal_consistency_checking reports an inconsistency on masterbranch  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
On Fri, Apr 13, 2018 at 02:15:35PM +0530, amul sul wrote:
> I have looked into this and found that the issue is in heap_xlog_delete -- we
> have missed to set the correct offset number from the target_tid when
> XLH_DELETE_IS_PARTITION_MOVE flag is set.

Oh, this looks good to me.  So when a row was moved across partitions
this could have caused incorrect tuple references on a standby, which
could have caused corruptions.

wal_consistency_checking is proving to be worth its cost here...
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Re: Built-in connection pooling
Next
From: Amit Langote
Date:
Subject: Re: wal_consistency_checking reports an inconsistency on masterbranch