Re: wal_consistency_checking reports an inconsistency on masterbranch - Mailing list pgsql-hackers

From Amit Langote
Subject Re: wal_consistency_checking reports an inconsistency on masterbranch
Date
Msg-id 0c11a775-3ff8-27fa-a7d4-d4e89761db97@lab.ntt.co.jp
Whole thread Raw
In response to Re: wal_consistency_checking reports an inconsistency on masterbranch  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 2018/04/13 19:08, Michael Paquier wrote:
> On Fri, Apr 13, 2018 at 02:15:35PM +0530, amul sul wrote:
>> I have looked into this and found that the issue is in heap_xlog_delete -- we
>> have missed to set the correct offset number from the target_tid when
>> XLH_DELETE_IS_PARTITION_MOVE flag is set.
> 
> Oh, this looks good to me.  So when a row was moved across partitions
> this could have caused incorrect tuple references on a standby, which
> could have caused corruptions.
> 
> wal_consistency_checking is proving to be worth its cost here...

+1

Thanks,
Amit



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: wal_consistency_checking reports an inconsistency on masterbranch
Next
From: Amit Langote
Date:
Subject: Re: crash with sql language partition support function