Re: Comment fixes in create_grouping_paths()add_paths_to_append_rel() - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: Comment fixes in create_grouping_paths()add_paths_to_append_rel()
Date
Msg-id 20180314164117.GM2416@tamriel.snowman.net
Whole thread Raw
In response to Comment fixes in create_grouping_paths() add_paths_to_append_rel()  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
Responses Re: Comment fixes in create_grouping_paths() add_paths_to_append_rel()  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
Greetings Ashutosh,

* Ashutosh Bapat (ashutosh.bapat@enterprisedb.com) wrote:
> Here are two patches fixing comments.

Thanks!

> 0001
> A comment in add_paths_to_append_rel() mentions the number of paths
> instead of number of workers by mistake. Fixed it.

This looks alright.

> 0002
> Commit b5635948ab165b6070e7d05d111f966e07570d81 added a single
> grouping_sets_data argument instead of two lists related to grouping
> sets to create_grouping_paths(), but forgot to update the prologue of
> the function. Fixed it.

This also looks good, but misses a similar mishap from that commit, in
the function header of get_number_of_groups().

Patch attached.

Will push soon.

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: ExplainProperty* and units
Next
From: Andres Freund
Date:
Subject: Re: ExplainProperty* and units