Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Fix warnings and typo in dshash - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] Fix warnings and typo in dshash
Date
Msg-id 20180302002957.njovdbubb6wofnzz@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] Fix warnings and typo in dshash  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Tree view 
On 2018-02-12 09:23:43 +1300, Thomas Munro wrote:
> On Mon, Sep 4, 2017 at 2:18 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> > On Sun, Sep 3, 2017 at 2:56 PM, Thomas Munro
> > <thomas.munro@enterprisedb.com> wrote:
> >> I think it should be (size_t) 1, not UINT64CONST(1).  See attached.
> >
> > Okay, that makes sense.  Do you think we should also change type
> > casting in BUCKETS_PER_PARTITION so that we are consistent?
> 
> +1
> 
> Here's a patch to fix that.  I was reminded to come back and tidy this
> up when I spotted a silly mistake in a nearby comment, also fixed in
> this patch.

Pushed.


Thanks,

Andres

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Rewrite of pg_dump TAP tests
Next
From: Andres Freund
Date:
Subject: Re: Removing shm_mq.c's volatile qualifiers