Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Fix warnings and typo in dshash - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: [HACKERS] Fix warnings and typo in dshash
Date
Msg-id CAEepm=3TuBb_LKfH7+AnkD8ZKyb+Facz_=hMNoHnxCEUxEpCyw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Fix warnings and typo in dshash  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [HACKERS] Fix warnings and typo in dshash  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Tree view 
On Mon, Sep 4, 2017 at 2:18 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Sun, Sep 3, 2017 at 2:56 PM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> I think it should be (size_t) 1, not UINT64CONST(1).  See attached.
>
> Okay, that makes sense.  Do you think we should also change type
> casting in BUCKETS_PER_PARTITION so that we are consistent?

+1

Here's a patch to fix that.  I was reminded to come back and tidy this
up when I spotted a silly mistake in a nearby comment, also fixed in
this patch.

-- 
Thomas Munro
http://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Sand Stone
Date:
Subject: persistent read cache
Next
From: Andrew Dunstan
Date:
Subject: Re: ALTER TABLE ADD COLUMN fast default