Re: [HACKERS] Small improvement to compactify_tuples - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] Small improvement to compactify_tuples
Date
Msg-id 20180301192206.2caqkwo2wzb777jq@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] Small improvement to compactify_tuples  (Yura Sokolov <funny.falcon@gmail.com>)
Responses Re: [HACKERS] Small improvement to compactify_tuples
List pgsql-hackers
Hi,

On 2018-02-25 21:39:46 +0300, Yura Sokolov wrote:
> > If that's the case then does it really make sense to make this change..?
> 
> I don't think it is really necessary to implement generic version
> through templated.

Why?

> Updated numbers are (same benchmark on same notebook, but with new
> master, new ubuntu and later patch version) (average among 6 runs):
> 
> master               - 16135tps
> with templated qsort - 16199tps
> with bucket sort     - 16956tps
> 
> Difference is still measurable, but less significant. I don't know why.
> 
> Rebased version of first patch (qsorted tamplate) is in atttach.

Hm, that's a bit underwhelming. It's nice to deduplicate, but 16135tps
-> 16199tps is barely statistically significant?

- Andres


pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: "failed to find parent tuple for heap-only tuple" error as anERRCODE_DATA_CORRUPTION ereport()
Next
From: David Steele
Date:
Subject: Re: "failed to find parent tuple for heap-only tuple" error as anERRCODE_DATA_CORRUPTION ereport()