Re: [HACKERS] ucs_wcwidth vintage - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [HACKERS] ucs_wcwidth vintage
Date
Msg-id 20171103173827.oc6pkew4uepkt3kp@alvherre.pgsql
Whole thread Raw
In response to [HACKERS] ucs_wcwidth vintage  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Thomas Munro wrote:
> Hi hackers,
> 
> src/backend/utils/mb/wchar.c contains a ~16 year old wcwidth
> implementation that originally arrived in commit df4cba68, but the
> upstream code[1] apparently continued evolving and there have been
> more Unicode revisions since.  It probably doesn't matter much: the
> observation made by Zr40 in the #postgresql IRC channel that lead me
> to guess that this code might be responsible is that emojis screw up
> psql's formatting, since current terminal emulators recognise them as
> double-width but PostgreSQL doesn't.  Still, it's interesting that we
> have artefacts deriving from various different frozen versions of the
> Unicode standard in the source tree, and that might affect some proper
> languages.
> 
> 🤔

Ah, thanks for the test case:

alvherre=# select '🤔', 'hello';
 ?column? │ ?column? 
──────────┼──────────
 🤔        │ hello
(1 fila)



-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Add some const decorations to prototypes
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] [PATCH] Add ALWAYS DEFERRED option for constraints