Re: [HACKERS] Add some const decorations to prototypes - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] Add some const decorations to prototypes
Date
Msg-id 1ef5f6af-c4d8-c8ab-aeb8-584fa397c041@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] Add some const decorations to prototypes  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Add some const decorations to prototypes  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 10/31/17 10:56, Tom Lane wrote:
>> Some functions have a strtol()-like behavior
>> where they take in a const char * and return a pointer into that as
>> another argument.  In those cases, I added a cast or two.
> ... but I'm not sure that it's an improvement in cases where you have to
> cast away the const somewhere else.  I realize that strtol has an ancient
> pedigree, but I do not think it's very good design.

Would you prefer leaving the input argument as char *, or change the
endptr argument to const as well?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] ucs_wcwidth vintage
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] ucs_wcwidth vintage