Re: [COMMITTERS] pgsql: Improve performance ofSendRowDescriptionMessage. - Mailing list pgsql-committers

From Andres Freund
Subject Re: [COMMITTERS] pgsql: Improve performance ofSendRowDescriptionMessage.
Date
Msg-id 20171012234829.efaorzn6daebxppc@alap3.anarazel.de
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Improve performance ofSendRowDescriptionMessage.  (Andres Freund <andres@anarazel.de>)
Responses Re: [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [COMMITTERS] pgsql: Improve performance ofSendRowDescriptionMessage.  (Noah Misch <noah@leadboat.com>)
List pgsql-committers
On 2017-10-12 16:08:44 -0700, Andres Freund wrote:
> wrap-gcc -D_THREAD_SAFE=1 -D_LARGE_FILES=1 -maix64 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement-Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv
-fexcess-precision=standard-g -O2 -I../../../src/include    -c -o auth.o auth.c
 
> auth.c: In function 'auth_peer':
> auth.c:2002:2: warning: implicit declaration of function 'getpeereid' [-Wimplicit-function-declaration]
>   if (getpeereid(port->sock, &uid, &gid) != 0)
>   ^
> wrap-gcc -D_THREAD_SAFE=1 -D_LARGE_FILES=1 -maix64 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement-Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv
-fexcess-precision=standard-g -O2 -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS  -DFRONTEND -DUNSAFE_STAT_OK
-I.-I../../../src/include   -I../../../src/port -I../../../src/port -DSO_MAJOR_VERSION=5  -c -o fe-connect.o
fe-connect.c
> fe-connect.c: In function 'PQconnectPoll':
> fe-connect.c:2382:6: warning: implicit declaration of function 'getpeereid' [-Wimplicit-function-declaration]
>       if (getpeereid(conn->sock, &uid, &gid) != 0)
>       ^
> 
> Looks like we're missing
> #include <sys/types.h>

Hm, it got removed as part of
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=9e3755ecb2d058f7d123dd35a2e1784006190962
but that's not an explanation, because
c.h includes sys/types.h. Which according to IBM's docs
https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.basetrf1/getpeereid.htm
is the right thing to include.  Given that xlc doesn't complain, I'll
just assume this is some issue with the headers gcc uses on aix, but I'm
far from confident.

Greetings,

Andres Freund


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: [COMMITTERS] pgsql: Use C99 restrict via pg_restrict,rather than restrict directly.
Next
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.