Re: [HACKERS] No parameter values checking while creating Altersubscription...Connection - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] No parameter values checking while creating Altersubscription...Connection
Date
Msg-id 20170525211852.c5u5crw3pxwrueh2@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] No parameter values checking while creating Altersubscription...Connection  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] No parameter values checking while creating Altersubscription...Connection  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
List pgsql-hackers
On 2017-05-25 17:08:57 -0400, Peter Eisentraut wrote:
> On 5/25/17 10:18, Masahiko Sawada wrote:
> >> postgres=# alter subscription c1 connection 'port=4000';
> >> ALTER SUBSCRIPTION
> >> postgres=# alter subscription c1 connection 'dbname=cc';
> >> ALTER SUBSCRIPTION
> >>
> > CREATE SUBSCRIPTION tries to connect to publisher to create
> > replication slot or to get table list for table synchronization, not
> > to check the connection parameter value. So if you specify connect =
> > false then CREATE SUBSCRIPTION doesn't try to connect.
> 
> We don't make a connection attempt as part of ALTER SUBSCRIPTION.  I
> guess we could just connect and disconnect to check that it works.

I think during reconfigurations it's quite useful to be able to do so
even if the other hosts aren't reachable that second.

- Andres



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: [HACKERS] Channel binding support for SCRAM-SHA-256
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Renaming a table to an array's autogenerated name