Re: [HACKERS] Change GetLastImportantRecPtr's definition? (wasSkipcheckpoints, archiving on idle systems.) - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] Change GetLastImportantRecPtr's definition? (wasSkipcheckpoints, archiving on idle systems.)
Date
Msg-id 20170505062736.2latenw7cd7tdn67@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] Change GetLastImportantRecPtr's definition? (wasSkipcheckpoints, archiving on idle systems.)  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [HACKERS] Change GetLastImportantRecPtr's definition? (wasSkipcheckpoints, archiving on idle systems.)  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Hi,

On 2017-05-05 11:50:12 +0530, Amit Kapila wrote:
> I see that EndPos can be updated in one of the cases after releasing
> the lock (refer below code). Won't that matter?

I can't see how it'd in the cases that'd matter for
GetLastImportantRecPtr() - but it'd probably good to note it in the
comment.

Thanks,

Andres



pgsql-hackers by date:

Previous
From: Rajkumar Raghuwanshi
Date:
Subject: Re: [HACKERS] Adding support for Default partition in partitioning
Next
From: Noah Misch
Date:
Subject: Re: [HACKERS] Time based lag tracking for logical replication