On 2017-04-13 12:56:14 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Cool. I wonder if we also should remove AtEOXact_CatCache()'s
> > cross-checks - the resowner replacement has been in place for a while,
> > and seems robust enough. They're now the biggest user of time.
>
> Hm, biggest user of time in what workload? I've not noticed that
> function particularly.
Just initdb. I presume it's because the catcaches will frequently be
relatively big there.
> I agree that it doesn't seem like we need to spend a lot of time
> cross-checking there, though. Maybe keep the code but #ifdef it
> under some nondefault debugging symbol.
Hm, if we want to keep it, maybe tie it to CLOBBER_CACHE_ALWAYS or such,
so it gets compiled at least sometimes? Not a great fit, but ...
Greetings,
Andres Freund
