Re: [HACKERS] parallel bitmapscan isn't exercised in regression tests - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] parallel bitmapscan isn't exercised in regression tests
Date
Msg-id 20170407175003.4xoa55lxbfenbac5@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] parallel bitmapscan isn't exercised in regression tests  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 2017-04-06 13:43:55 -0700, Andres Freund wrote:
> On 2017-04-06 10:00:32 +0530, Dilip Kumar wrote:
> > On Tue, Apr 4, 2017 at 5:51 AM, Dilip Kumar <dilipbalaut@gmail.com> wrote:
> > > Sure I can do that, In attached patch, I only fixed the problem of not
> > > executing the bitmap test.  Now, I will add few cases to cover other
> > > parts especially rescan and prefetching logic.
> > 
> > I have added two test cases to cover rescan, prefetch and lossy pages
> > logic for parallel bitmap.  I have removed the existing case because
> > these two new cases will be enough to cover that part as well.
> > 
> > Now, nodeBitmapHeapScan.c has 95.5% of line coverage.
> 
> Great!  Pushed.

At some point it might also be a good idea to compare parallel and
non-parallel results.  It's obviously quite possible to break semantics
with parallelism...

- Andres



pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: [HACKERS] recent deadlock regression test failures
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] recent deadlock regression test failures