Re: [HACKERS] Time to change pg_regress diffs to unified by default? - Mailing list pgsql-hackers

From Noah Misch
Subject Re: [HACKERS] Time to change pg_regress diffs to unified by default?
Date
Msg-id 20170407021431.GB2658646@tornado.leadboat.com
Whole thread Raw
In response to Re: [HACKERS] Time to change pg_regress diffs to unified by default?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Time to change pg_regress diffs to unified by default?  (Christoph Berg <myon@debian.org>)
List pgsql-hackers
On Thu, Apr 06, 2017 at 07:01:32PM -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > I personally, and I know of a bunch of other regular contributors, find
> > context diffs very hard to read.  Besides general dislike, for things
> > like regression test output context diffs are just not well suited.
> 
> Personally, I disagree completely.  Unified diffs are utterly unreadable
> for anything beyond trivial cases of small well-separated changes.
> 
> It's possible that regression failure diffs will usually fall into that
> category, but I'm not convinced.

For reading patches, I frequently use both formats.  Overall, I perhaps read
unified 3/4 of the time and context 1/4 of the time.

For regression diffs, I use PG_REGRESS_DIFF_OPTS=-u and have never converted a
regression diff to context form.  Hence, +1 for the proposed change.



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: [HACKERS] Time to change pg_regress diffs to unified by default?
Next
From: Craig Ringer
Date:
Subject: Re: [HACKERS] Faster methods for getting SPI results (460% improvement)